PERF: Define PeriodArray._values_for_argsort #24083
Merged
+3
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR speeds up
.groupby()
and.set_index()
operations involving aPeriodArray
by 25-64x:The underlying issue was that
pd.core.algorithms.factorize()
callsargsort()
on the input arrays. Calling this resulted in rawPeriod
objects being sorted via equality comparisons that also generatedOffset
objects. Assuming all elements of the array have the same frequency, we can simply sort the underlyingordinals
and achieve the same result far faster.git diff upstream/master -u -- "*.py" | flake8 --diff